Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping connect-mongo broke openshift deploy #1844

Closed
unsalted opened this issue May 3, 2016 · 5 comments
Closed

bumping connect-mongo broke openshift deploy #1844

unsalted opened this issue May 3, 2016 · 5 comments
Assignees

Comments

@unsalted
Copy link

unsalted commented May 3, 2016

Bumping the version of connect-mongo creates an error on fresh deployment to openshift.
Bringing the version back fixed the problem.

Here is potential issue #1782

Openshift Log:

/var/lib/openshift/XXXXXXXXXXXX/app-root/runtime/repo/node_modules/connect-mongo/src/index.js:3
const Promise = require('bluebird');
^^^^^
SyntaxError: Use of const in strict mode.
Item Version
generator-angular-fullstack 3.6.1
Node 0.10
Operating System RHEL Openshift
Item Answer
Transpiler Babel
Markup HTML
CSS LESS
Router ui-router
Build Tool Grunt
Client Tests Mocha
DB MongoDB
Auth Y
@Awk34
Copy link
Member

Awk34 commented May 3, 2016

Mmm, this is because of the quite old Node version you & Openshift are using. For now I'd suggest re-installing the latest connect-mongo and importing connect-mongo/es5 instead of connect-mongo, or updating to Node 4.x.x+

@unsalted
Copy link
Author

unsalted commented May 3, 2016

Ideally openshift would have a more up to date version of Node, I run 4.x locally but alas community managed deployments are a ways behind. Thanks for the advice.

@Awk34
Copy link
Member

Awk34 commented May 3, 2016

@unsalted would adding something to the readme about updating the node version in Openshift help? I found this article: https://blog.openshift.com/any-version-of-nodejs-you-want-in-the-cloud-openshift-does-it-paas-style/

@Awk34 Awk34 self-assigned this May 3, 2016
@unsalted
Copy link
Author

unsalted commented May 3, 2016

@Awk34 I suppose it would be, I will have to look into how that would work with the app deployment, as you know when using buildcontrol it decides the node module it deploys as. Prior to this change I quite literally didn't need to think at all about openshift deployments using angular-fullstack, just let my fingers do the walking and trust that it was configured to work. I could setup an account for a client, deploy to that account and point a dev domain in under an hour which was awesome. BTW angular-fullstack makes my life so much simpler thank you ; )

@Awk34
Copy link
Member

Awk34 commented May 6, 2016

@unsalted I think what I might do for now is include connect-mongo/es5 if an older Node version is detected.

@Awk34 Awk34 closed this as completed in 63fb77f May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants