Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

fix(dependencies): remove dependencies on remove event #585 #673

Closed
wants to merge 3 commits into from

Conversation

11joselu
Copy link
Contributor

@11joselu 11joselu commented Oct 6, 2016

UPDATE

Dependency still in task model

On model data -> remove event

  • Remove jsPlumb connector
  • Remove dependency from Task model
  • Remove dependency from Dependencies Manager Object
  • Raise dependencies.remove event

@11joselu 11joselu changed the title fix(dependencies): remove dependencies fromTask model on remove event #585 fix(dependencies): remove dependencies on remove event #585 Oct 6, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.727% when pulling b1a08e5 on 11joselu:issue-585 into e7d0e44 on angular-gantt:master.

Copy link
Member

@Toilal Toilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you ! I still need to test and read more to understand changes, i'll try to do it tonight.

@@ -93,11 +96,12 @@
* @param task Task defining the dependency.
* @param model Model object for the dependency.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add isDraw @param jsDoc

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.727% when pulling f3dfb2f on 11joselu:issue-585 into e7d0e44 on angular-gantt:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 51.739% when pulling c296948 on 11joselu:issue-585 into e7d0e44 on angular-gantt:master.

@Toilal
Copy link
Member

Toilal commented Oct 6, 2016

Thank you, I've cherry-picked your commits with few changes, main one is to implement this behavior also when From Task is missing, not only To Task.

@Toilal Toilal closed this Oct 6, 2016
@11joselu 11joselu deleted the issue-585 branch October 7, 2016 07:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants