Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

predefined [countries] input not working #42

Closed
SnappingTurtle opened this issue Sep 29, 2020 · 1 comment
Closed

predefined [countries] input not working #42

SnappingTurtle opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
bug Something isn't working ready

Comments

@SnappingTurtle
Copy link

I rolled back to version 1.0.1 so that I could overcome the bug where default input label does not show on first render, but now, I am trying to input a predefined countries list (to overcome terrible performance) and it does not recognize the countries list input.

To Reproduce
Add a select-country component to your layout.
configure with [countries]="predefinedCountries" to show a subset of countries.
configure a list in your controller predefinedCountries: Country[] = {...} with a short list.

Expected behavior
I would expect the control to show the short list of predefined countries.
However, the entire list (slow loading) of countries is still present.

Screenshots

Additional context
Is this input supported in version 1.0.1 or was it added in later versions?

@AnthonyNahas AnthonyNahas self-assigned this Oct 4, 2020
@AnthonyNahas AnthonyNahas added bug Something isn't working ready labels Oct 4, 2020
@AnthonyNahas
Copy link
Member

@KingDarBoja you have right! Please when using the newest version 3.0.0 please use [value] instead of [country]

Finally, I've released a new major version of the library 3.0.0

With this release

Bildschirmfoto 2020-10-23 um 22 36 45

https://github.com/angular-material-extensions/select-country/releases/tag/3.0.0

If you love this library please share it with your team and friends and please make sure that your are not missing any
cool angular library or component within my angular material extensions

thank you all and cheers 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready
Projects
None yet
Development

No branches or pull requests

2 participants