Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support angular compiler strict templates #353

Merged
merged 1 commit into from
Sep 3, 2023
Merged

feat: support angular compiler strict templates #353

merged 1 commit into from
Sep 3, 2023

Conversation

Harpush
Copy link
Collaborator

@Harpush Harpush commented Sep 2, 2023

Fix #220

Features:

  1. size is typed as * or number
  2. number and boolean inputs support strings too (prop="40" and prop="true")
  3. New types: ISplitDirection, ISplitDir, IAreaSize, ISplitUnit
  4. Fully compatible with strict templates considering all above too

@Harpush Harpush requested a review from beeman September 2, 2023 10:36
Harpush
Harpush commented Sep 2, 2023
View reviewed changes
angular.json Show resolved Hide resolved
beeman
beeman approved these changes Sep 2, 2023
View reviewed changes
Copy link
Collaborator

@beeman beeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, happy to merge and publish!

Closes #289

@beeman beeman merged commit 2f77a67 into angular-split:main Sep 3, 2023
1 check passed
@beeman
Copy link
Collaborator

beeman commented Sep 3, 2023

This is now published as angular-split@16.2.0

@Harpush Harpush deleted the strict-templates-correct-size-type branch September 3, 2023 14:14
This was referenced Jan 24, 2024
Closed
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Closed
@github-actions github-actions bot mentioned this pull request May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeman beeman beeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect @Input size typing when strictTemplates is enabled
2 participants
@Harpush @beeman