Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove lodash dependency #356

Merged
merged 1 commit into from
Sep 5, 2023
Merged

chore: remove lodash dependency #356

merged 1 commit into from
Sep 5, 2023

Conversation

beeman
Copy link
Collaborator

@beeman beeman commented Sep 4, 2023

The demo app depended on lodash for cloneDeep, but we can use structuredClone which is supported in all major browsers.

It removes this warning:

Warning: /Users/beeman/dev/github/angular-split/angular-split/src/app/examples/workspace-localstorage/workspace-localstorage.component.ts depends on 'lodash'. CommonJS or AMD dependencies can cause optimization bailouts.

@beeman beeman requested a review from Harpush September 4, 2023 20:38
Harpush
Harpush approved these changes Sep 5, 2023
View reviewed changes
Copy link
Collaborator

@Harpush Harpush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to get rid of it!

@beeman beeman merged commit c5e2d5a into main Sep 5, 2023
1 check passed
@beeman beeman deleted the beeman/remove-lodash branch September 5, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harpush Harpush Harpush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@beeman @Harpush