Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Commit

Permalink
feat(build): introduce module definition
Browse files Browse the repository at this point in the history
This ensures no global variables with an IIFE and export the moduel with a universal module definition (UMD).

Solves #1001
  • Loading branch information
luaks authored and knalli committed Apr 12, 2015
1 parent a361fd0 commit 00b73ff
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 3 deletions.
47 changes: 44 additions & 3 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -533,6 +533,41 @@ module.exports = function (grunt) {
}
},

umd: {
'core': {
src: '<%= concat.core.dest %>',
dest: '<%= concat.core.dest %>'
},
'messageformat_interpolation': {
src: '<%= concat.messageformat_interpolation.dest %>',
dest: '<%= concat.messageformat_interpolation.dest %>'
},
'handler_log': {
src: '<%= concat.handler_log.dest %>',
dest: '<%= concat.handler_log.dest %>'
},
'loader_partial': {
src: '<%= concat.loader_partial.dest %>',
dest: '<%= concat.loader_partial.dest %>'
},
'loader_static_files': {
src: '<%= concat.loader_static_files.dest %>',
dest: '<%= concat.loader_static_files.dest %>'
},
'loader_url': {
src: '<%= concat.loader_url.dest %>',
dest: '<%= concat.loader_url.dest %>'
},
'storage_cookie': {
src: '<%= concat.storage_cookie.dest %>',
dest: '<%= concat.storage_cookie.dest %>'
},
'storage_local': {
src: '<%= concat.storage_local.dest %>',
dest: '<%= concat.storage_local.dest %>'
}
},

version: {
options: {
prefix: 'var version\\s+=\\s+[\'"]'
Expand All @@ -547,8 +582,6 @@ module.exports = function (grunt) {
});




grunt.registerTask('default', ['jshint:all', 'karma']);
grunt.registerTask('test', ['jshint:all', 'karma:unit', 'karma:midway']);
grunt.registerTask('install-test', ['bower-install-simple']);
Expand Down Expand Up @@ -585,6 +618,7 @@ module.exports = function (grunt) {
'jshint:core',
'concat:core',
'version',
'umd:core',
'ngAnnotate:core',
'concat:banner_core',
'uglify:core'
Expand All @@ -593,6 +627,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:messageformat_interpolation', [
'jshint:messageformat_interpolation',
'concat:messageformat_interpolation',
'umd:messageformat_interpolation',
'ngAnnotate:messageformat_interpolation',
'concat:banner_messageformat_interpolation',
'uglify:messageformat_interpolation'
Expand All @@ -601,6 +636,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:handler_log', [
'jshint:handler_log',
'concat:handler_log',
'umd:handler_log',
'ngAnnotate:handler_log',
'concat:banner_handler_log',
'uglify:handler_log'
Expand All @@ -609,6 +645,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:loader_partial', [
'jshint:loader_partial',
'concat:loader_partial',
'umd:loader_partial',
'ngAnnotate:loader_partial',
'concat:banner_loader_partial',
'uglify:loader_partial'
Expand All @@ -617,6 +654,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:loader_static_files', [
'jshint:loader_static_files',
'concat:loader_static_files',
'umd:loader_static_files',
'ngAnnotate:loader_static_files',
'concat:banner_loader_static_files',
'uglify:loader_static_files'
Expand All @@ -625,6 +663,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:loader_url', [
'jshint:loader_url',
'concat:loader_url',
'umd:loader_url',
'ngAnnotate:loader_url',
'concat:banner_loader_url',
'uglify:loader_url'
Expand All @@ -633,6 +672,7 @@ module.exports = function (grunt) {
grunt.registerTask('build:storage_cookie', [
'jshint:storage_cookie',
'concat:storage_cookie',
'umd:storage_cookie',
'ngAnnotate:storage_cookie',
'concat:banner_storage_cookie',
'uglify:storage_cookie'
Expand All @@ -641,13 +681,14 @@ module.exports = function (grunt) {
grunt.registerTask('build:storage_local', [
'jshint:storage_local',
'concat:storage_local',
'umd:storage_local',
'ngAnnotate:storage_local',
'concat:banner_storage_local',
'uglify:storage_local'
]);


// For development purpose.
grunt.registerTask('dev', ['jshint', 'karma:unit', 'concat', 'copy:demo', 'watch:livereload']);
grunt.registerTask('dev', ['jshint', 'karma:unit', 'concat', 'copy:demo', 'watch:livereload']);
grunt.registerTask('server', ['express', 'express-keepalive']);
};
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
"grunt-karma": "~0.9.0",
"grunt-ng-annotate": "^0.8.0",
"grunt-ngdocs": "~0.1.11",
"grunt-umd": "^2.3.3",
"grunt-version": "~0.3.0",
"jasmine-core": "^2.1.3",
"karma": "~0.12.28",
Expand Down

0 comments on commit 00b73ff

Please sign in to comment.