Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Added lang_only as new langTagResolver #1181

Closed
wants to merge 1 commit into from

Conversation

antony-k1208
Copy link

Added possibility to be able to get only the lang tag as result, in order to limit the language files to one for each language, i.e. locale-de.json, locale-en.json. Especially useful when using the staticFilesLoader.

Added possibility to be able to get only the lang tag as result, in order to limit the language files to one for each language, i.e. locale-de.json, locale-en.json. Especially useful when using the staticFilesLoader.
@knalli
Copy link
Member

knalli commented Aug 30, 2015

@ThinklabsGbR

Thank you for contribution. Please follow https://github.com/angular-translate/angular-translate/blob/master/CONTRIBUTING.md which contains some notes about contribution steps in this project.

Particular in this case, I remark the followings:

  • apply a proper commit message (see in guideline about conventional changelog)
  • add a test (for the other resolvers they are included, just search for bcp47 in translate.determineLocale.spec.js)
  • please rename the resolver name: lang_only => iso639-1
  • the new option should be mentioned in the list of available (incl. an example, i.e. same as in test?): $translateProvider.uniformLanguageTag

@knalli
Copy link
Member

knalli commented Mar 5, 2016

Superseeded by 1e037ec

@knalli knalli closed this Mar 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants