Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

MissingTranslationHandlerLog changes functionality #1600

Closed
JaZo opened this issue Sep 29, 2016 · 1 comment
Closed

MissingTranslationHandlerLog changes functionality #1600

JaZo opened this issue Sep 29, 2016 · 1 comment

Comments

@JaZo
Copy link
Contributor

JaZo commented Sep 29, 2016

Subject of the issue

When using the MissingTranslationHandlerLog, the $translate service does not reject the translation-promise when the translation is missing.

Your environment

  • version of angular-translate: 2.12.1
  • version of angular-translate-handler-log: 2.12.1
  • version of angular: 1.5.8
  • which browser and its version: Firefox Dev 51.0

Steps to reproduce

Please see these plunkers: without missing-translation-handler-log and with missing-translation-handler-log.

Expected behaviour

I would expect that the $translate service always rejects the translation-promise with or without using the MissingTranslationHandlerLog as stated in the documentation.

Actual behaviour

The $translate service resolves the translation-promise when using the MissingTranslationHandlerLog.

@knalli
Copy link
Member

knalli commented Oct 9, 2016

Do you like providing a PR?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants