Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

Fix https version of angular-translate.github.io #513

Closed
knalli opened this issue Apr 19, 2014 · 4 comments
Closed

Fix https version of angular-translate.github.io #513

knalli opened this issue Apr 19, 2014 · 4 comments

Comments

@knalli
Copy link
Member

knalli commented Apr 19, 2014

Currently, the secure version of API & Guide is totally broken.

https://angular-translate.github.io/docs/#/api

This should be fixable using urls without the protcoll, i.e. //rawgithub.com/angular/bower-angular-cookies/master/angular-cookies.min.js

@endorama
Copy link

+1

@knalli
Copy link
Member Author

knalli commented May 31, 2014

@PascalPrecht do we serve an updated version already? because it still shows errors...

@HansCz
Copy link

HansCz commented May 31, 2014

Here's what I get in the chrome console:

[blocked] The page at 'https://angular-translate.github.io/docs/#/api' was loaded over HTTPS, but ran insecure content from 'http://rawgithub.com/angular-translate/bower-angular-translate-handler-log/master/angular-translate-handler-log.min.js': this content should also be loaded over HTTPS.

maybe finding the string 'http://rawgithub.com/angular-translate/bower-angular-translate-handler-log/master/angular-translate-handler-log.min.js' and replacing it with '//rawgithub.com/angular-translate/bower-angular-translate-handler-log/master/angular-translate-handler-log.min.js' would fix the issue?

I'd try it out it myself, but have no idea how to test it before submitting a pull request. Anybody know how?

@knalli
Copy link
Member Author

knalli commented May 31, 2014

Sure, I'm not sure what there is serving right now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants