Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

$translate.use does not respect the language aliases defined by registerAvailableLanguageKeys #530

Closed
spawnedc opened this issue Apr 28, 2014 · 4 comments

Comments

@spawnedc
Copy link

Here's the plunk: http://plnkr.co/edit/lyOiwSE4ugLIWmbViJsC?p=preview

Basically, when I use $translate.use('en_GB'), I expect it to load the en language since en_GB is already linked to the alias en. Should I create a PR for this?

@tspaeth
Copy link
Member

tspaeth commented Apr 28, 2014

Isn't it going in the same direction as #426 at the end?!

@spawnedc
Copy link
Author

Quite similar, but different issues at the same time. Maybe I can fix both in the same PR.

@tspaeth
Copy link
Member

tspaeth commented Apr 28, 2014

That would be a great idea :-)
If you have the time - feel free to provide a PR. And before you make the same mistake as a few others: branch from/send PR to canary branch :-)

@spawnedc
Copy link
Author

Thanks for the heads up, I was just about the start working from the master branch :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants