Methods in $callbacks to support promises?

[ktulufrozen]

I have the following scenario:

• the user drags a node to a new location
• before drop she is asked for a confirmation whether she is sure she wants to make the change
• if yes, then make the change
• if no, cancel the whole drag and drop

The way I implemented the confirmation is by using a modal which returns the answer in a promise. I trigger the modal in the "beforeDrop" method, but since it does not support promises, I can not cancel the event if the user chooses "No". As a workaround I have to manually put the node back where it was in this case.

It would be nice if all methods would support promises so that async operations can be done in the $callbacks methods.

Is this possible or in plan to do?

[didando8a]

I am having exactly the same problem since I am trying to use modals rather than confirm.

Thanks

[kmsheng]

+1 for this feature, promise is needed here

[bronielsen]

Hi both. I had the same problem and found a solution that works. Unfortunately it involved changing the code. The change still works with the current version.

I have decided anyway, that I need to try to get it into the main branch code anyway, so I will make a branch and implement it soon.
See #262

[bronielsen]

I made two branches to implement it. Take a look and comment.

master...bronielsen:bronielsen-patch-confirmationDialog

and

master...bronielsen:bronielsen-patch-confirmationDialog-1

[StefanCodes]

I decided to go for it and implement this using $q (Angular's promise service) as the original request stated. See PR #589

I don't think this will break anything or any existing code, but I've only tested it with my own app and with the demo pages, and only on a desktop web browser. Feedback would be appreciated.

[jacobscarter]

Closing this issue due to inactivity. See #815 for more information.
Please create a new issue is this still occurs with the current version of the component.