-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dragging: Horizontal movement not recognized #562
Comments
Finding the piece of code that causes this behavior isn't that hard. It's the |
+1. I'm having the same problem. |
+1 |
for reference, here the code that @svenjunga metioned above in context
|
+1 |
@zachlysobey have you found a better solution to this than my proposed hack? This seems to be a annoying bug to many people. |
@svenjunga nope, haven't even tried or looked into it; Just tracked down that line of code in the hopes that it might make it a little easier for someone to dig into this and perhaps submit a PR. |
+1 |
I think I have a fix for this I will implement soon, horizontal movement is not recognized because it is checking to see if you are moving a node within its own tree to "un-nest" it. I will add a bit that stops checking for that as soon as you leave the origin tree, so horizontal movement beyond that will be recognized as a node traveling. Not sure if this makes sense but I'll have the fix soon and can show via demo rather than just explaining it. |
The fix I implemented here now uses tree IDs to determine if you are re-adjusting nestings rather than pixel measurements on the screen. |
PR #824 |
Fix available in v2.22.0 |
A tree does not accept a node that is dragged with almost only horizontal movement. Only vertical movement seems to be recognized. See the following example:
Tested with Chromium for Windows and Mac.
The text was updated successfully, but these errors were encountered: