Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#611 Put drag element to the $rootElement instead of the body #612

Merged
merged 1 commit into from
Oct 13, 2015
Merged

#611 Put drag element to the $rootElement instead of the body #612

merged 1 commit into from
Oct 13, 2015

Conversation

dangoodman
Copy link

Fixes #611

@dangoodman
Copy link
Author

I'm not sure, did the travis build failed due to my changes?

@StefanCodes
Copy link
Contributor

I'm able to run the e2e tests locally and they all pass, but the Travis logs show that Protractor failing with an exception. I don't see how your changes could result in this error.

[15:21:00] Starting 'test:e2e'...
[15:21:00] Starting 'protractor'...
[15:21:00] Finished 'test:e2e' after 82 ms
/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:126
                    throw e;
                          ^
TypeError: Object #<Object> has no method 'parse'
    at Function.ConfigParser.resolveFilePatterns (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/lib/configParser.js:102:29)
    at new TaskScheduler (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/lib/taskScheduler.js:31:31)
    at /home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/lib/launcher.js:180:21
    at _fulfilled (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:797:54)
    at self.promiseDispatch.done (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:826:30)
    at Promise.promise.promiseDispatch (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:759:13)
    at /home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:573:44
    at flush (/home/travis/build/angular-ui-tree/angular-ui-tree/node_modules/protractor/node_modules/q/q.js:108:17)
    at process._tickCallback (node.js:448:13)
    at Function.Module.runMain (module.js:499:11)
/home/travis/build/angular-ui-tree/angular-ui-tree/tasks/protractor.js:11
        throw error;
              ^
Error: protractor exited with code 8
npm ERR! Test failed.  See above for more details.
npm ERR! not ok code 0

@Voles did you encounter anything like this when you were setting up the e2e tests?

@dangoodman
Copy link
Author

@StefanCodes, thank you for response. Sadly @Voles did not please us with his comment.

Well, now travis build goes successfully. I've just forced it to re-run and it went ok. Not sure what has been changed. What I can say for sure is that the commit did not changed.

For now, is there any reason to not merge the commit?

@Voles Voles changed the title #611 Put drag element to the instead of 'body' #611 Put drag element to the $rootElement instead of the body Oct 13, 2015
Voles pushed a commit that referenced this pull request Oct 13, 2015
#611 Put drag element to the $rootElement instead of the body
@Voles Voles merged commit f0ea6da into angular-ui-tree:master Oct 13, 2015
@Voles
Copy link
Member

Voles commented Oct 13, 2015

Sorry for the late reply. The PR looks good, merged!

@dangoodman
Copy link
Author

Thanks!

@Voles
Copy link
Member

Voles commented Oct 13, 2015

@dangoodman are you interested in helping us with further development of the component? :-)

@dangoodman
Copy link
Author

Yep. I'm going to do a couple of drag-n-drop UX improvements. Hopefully you'll accept them. Or do you mean something else?

@Voles
Copy link
Member

Voles commented Oct 13, 2015

No, that would be perfect! Looking forward 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants