-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#611 Put drag element to the $rootElement instead of the body #612
#611 Put drag element to the $rootElement instead of the body #612
Conversation
I'm not sure, did the travis build failed due to my changes? |
I'm able to run the e2e tests locally and they all pass, but the Travis logs show that Protractor failing with an exception. I don't see how your changes could result in this error.
@Voles did you encounter anything like this when you were setting up the e2e tests? |
@StefanCodes, thank you for response. Sadly @Voles did not please us with his comment. Well, now travis build goes successfully. I've just forced it to re-run and it went ok. Not sure what has been changed. What I can say for sure is that the commit did not changed. For now, is there any reason to not merge the commit? |
#611 Put drag element to the $rootElement instead of the body
Sorry for the late reply. The PR looks good, merged! |
Thanks! |
@dangoodman are you interested in helping us with further development of the component? :-) |
Yep. I'm going to do a couple of drag-n-drop UX improvements. Hopefully you'll accept them. Or do you mean something else? |
No, that would be perfect! Looking forward 👍 |
Fixes #611