Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demos and examples aren't working? #680

Closed
ittikorns opened this issue Dec 21, 2015 · 4 comments
Closed

Demos and examples aren't working? #680

ittikorns opened this issue Dec 21, 2015 · 4 comments
Labels

Comments

@ittikorns
Copy link

I was trying to figure out why drag and drop table rows doesn't work on my site. Then I come back and check the demos again and it seems like it doesn't work as well.

http://angular-ui-tree.github.io/angular-ui-tree/#/table-example

When you drop the element it just go back into the same order.

@zachlysobey
Copy link
Contributor

No idea how to fix, but I think I can write a e2e test to confirm this as broken and prevent future regressions.

@StefanCodes
Copy link
Contributor

Argh, that was caused by #589 - my bad.
The problem is that beforeDrop only passes (and thus processes the drop event) when the caller code implements the beforeDrop callback and return truthy.
Right now if it's not implemented, ui-tree will assume the drop event was rejected and undo the drop.

I can submit a PR for this tonight. Sorry, that was sloppy.

@zachlysobey
Copy link
Contributor

I tried to get an e2e test (#682) for this, but it's not working as expected...

@StefanCodes
Copy link
Contributor

Submitted #683

@Voles Voles closed this as completed in bb15c35 Dec 23, 2015
Voles pushed a commit that referenced this issue Dec 23, 2015
Fix #680 (drag-drop not working if beforeDrop is not implemented)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants