Prevents child node scope with no children to be counted in depth. #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Whyves nice improvement! Can you bring your PR up-to-date with the |
|
Tried to rebase but you changed the name attribute in package.json to "AngularJS UI Tree" and that prevents me from running "npm install" it complains about "AngularJS UI Tree" to be invalid. Putting "-" instead of spaces fix the problem. May I suggest that you rename "AngularJS UI Tree" to "angular-ui-tree" which seems more standard. I am under Ubuntu. Once this is fixed, I will rebase my changes. |
|
Fixed, sorry for the inconvenience... |
|
There you go, PR up-to-date. Sorry for the multiple commits. I had a few issues with jscs :-) |
Voles
pushed a commit
that referenced
this pull request
May 8, 2015
Prevents child node scope with no children to be counted in depth.
|
Thanks for this, @Whyves! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When specifying maxDepth and using a template in ng-include to generate the tree nodes, a template is created for empty children. This causes the logic in maxSubDepth to include the depth of non-existent children thus going over the max depth limit and preventing node moves even when they were valid. I have added a test for this.