Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves/Fixes data-drag-delay to actually delay dragStart. #444

Merged
merged 1 commit into from May 2, 2015

Conversation

foglerek
Copy link
Contributor

Fixes collisions with ng-click on ui-tree-node elements.

Builds on pull request #393, by adding the dragStart callback to the dragStart method.

@samuv
Copy link

samuv commented Apr 30, 2015

+1

1 similar comment
@msvbg
Copy link

msvbg commented Apr 30, 2015

+1

@Voles
Copy link
Member

Voles commented May 2, 2015

Reviewed and tested. Great fix! Please make your PR up-to-date with the master branch, so it can be merged.

Thanks again 🍰

Moved dragStart callback firing to dragStart() method.
@foglerek
Copy link
Contributor Author

foglerek commented May 2, 2015

Done!

Voles pushed a commit that referenced this pull request May 2, 2015
Improves/Fixes data-drag-delay to actually delay dragStart.
@Voles Voles merged commit b6dc364 into angular-ui-tree:master May 2, 2015
@Voles
Copy link
Member

Voles commented May 2, 2015

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants