Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #454: fix placeholder width #470

Closed

Conversation

jeremy-albuixech
Copy link

No description provided.

@Voles
Copy link
Member

Voles commented Jun 2, 2015

Thanks for this PR @Albi34. Can you briefly elaborate the description your fix? Thanks!

@jeremy-albuixech
Copy link
Author

Hi @Voles , I just added back the line that calculated the width of the placeholder element. It's on the uiTreeNode.js directive, line 135.
I believe it might have been removed in a past merge (that one if I'm not mistaken: 432c73b#diff-2bd42e539aeba5277f65f2599dfc0338).

@Voles
Copy link
Member

Voles commented Jun 3, 2015

Great. Is it possible to separate your other changes from this PR to keep things organised? Thanks!

@jeremy-albuixech
Copy link
Author

@Voles I just synced my fork and updated the pull request with a cleaned-up version. Sorry about the delay, had a crazy week!

@Voles
Copy link
Member

Voles commented Jul 8, 2015

@Albi34 still not able to merge. I've updated the Bower.json file. Maybe it's best to only update the files in the source/ directory? So without creating the dist files.

Sorry for the trouble, I can't resolve the merge conflict myself as I don't have write access to your repository.

Voles pushed a commit that referenced this pull request Jul 28, 2015
Related issue #454
Related PR #470
@Voles
Copy link
Member

Voles commented Jul 28, 2015

@Albi34 I've added you're fix to a separate branch so we can release your fix in the next version. Thanks very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants