Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #511 - $parentNodeScope is null and can not access $id #512

Merged
merged 2 commits into from Jul 12, 2015

Conversation

joechimo
Copy link
Contributor

Encountered an ongoing issue after a recent merge into master to fix an edge case. The following was the error:

TypeError: Cannot read property '$id' of null
    at Object.dragInfo.apply (http://127.0.0.1:8080/js/vendor.js:31906:85)
    at http://127.0.0.1:8080/js/vendor.js:31595:30
    at Scope.$get.Scope.$eval (http://127.0.0.1:8080/js/vendor.js:14466:28)
    at Scope.$get.Scope.$apply (http://127.0.0.1:8080/js/vendor.js:14565:23)
    at link.dragEnd (http://127.0.0.1:8080/js/vendor.js:31594:36)
    at HTMLDocument.link.dragEndEvent (http://127.0.0.1:8080/js/vendor.js:31636:15)
    at HTMLDocument.eventHandler (http://127.0.0.1:8080/js/vendor.js:3032:21) undefined

Joseph Cimaszewski and others added 2 commits July 12, 2015 12:37
…ction when checking for $parentNodeScope.$id when $parentNodeScope.$id was null. This happened 100% of the time when attempting to nest a node into another node if the source node was not positioned directly after the destination node.
…tNodeScope-is-null

Issue angular-ui-tree#511 - $parentNodeScope is null and can not access $id
Voles pushed a commit that referenced this pull request Jul 12, 2015
Issue #511 - $parentNodeScope is null and can not access $id
@Voles Voles merged commit cbdb469 into angular-ui-tree:master Jul 12, 2015
@Voles
Copy link
Member

Voles commented Jul 12, 2015

Thanks for your work! Merged.

@marsanla
Copy link

Is this merge, updated in Bower?

@Voles
Copy link
Member

Voles commented Jul 31, 2015

Yes v2.7.0 is just released!

@marsanla
Copy link

marsanla commented Aug 3, 2015

thanks!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants