Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property 'childNodes' of undefined #650

Merged
merged 1 commit into from
Nov 23, 2015

Conversation

thecatontheflat
Copy link
Contributor

Extra check for recursive call of the countSubTreeDepth

screenshot 2015-11-15 20 57 19

Extra check for recursive call of the countSubTreeDepth
Voles pushed a commit that referenced this pull request Nov 23, 2015
Cannot read property 'childNodes' of undefined
@Voles Voles merged commit 7df850e into angular-ui-tree:master Nov 23, 2015
@Voles
Copy link
Member

Voles commented Nov 23, 2015

Thanks! 👍

@thecatontheflat
Copy link
Contributor Author

No problem! Don't forget to update the minified version ;)

@brianfeister
Copy link

@Voles. I'm running into this, can we merge this PR?

@ConnectedReasoning
Copy link

This is happening to me even with the file change

@carolinagc
Copy link

For some reason, this fix is not present in v2.17 but you can do a patch but applying the fix described in 7df850e

@carolinagc
Copy link

carolinagc commented Sep 12, 2016

Hey @jacobscarter , can you check this issue?
There is commit that was supposed to be merged, this one:
7df850e

but also in current version it does not appear
https://github.com/angular-ui-tree/angular-ui-tree/blob/master/dist/angular-ui-tree.js#L168

also by adding as a patch works.
Thanks!!!

@jacobscarter
Copy link
Contributor

Hey @carolinagc we just recently got our merging and releasing process documented so hopefully this wont happen again! I'll fix it now

@jacobscarter
Copy link
Contributor

Version 2.21.1 now has the fix

@carolinagc
Copy link

@jacobscarter great!!! thanks!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants