Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Syntax highlighting doesn't work with data- attributes #44

Open
feimosi opened this issue Sep 22, 2015 · 6 comments
Open

Syntax highlighting doesn't work with data- attributes #44

feimosi opened this issue Sep 22, 2015 · 6 comments

Comments

@feimosi
Copy link

feimosi commented Sep 22, 2015

It'd be nice if the syntax highlighting worked with attributes prefixed with data-.

@feimosi
Copy link
Author

feimosi commented Sep 24, 2015

Also it doesn't highlight every needed directive e.g ng-required, ng-class or ng-show. I'd really appreciate it if you could add support for these.

@outsideris outsideris self-assigned this Oct 7, 2015
outsideris added a commit that referenced this issue Oct 10, 2015
outsideris added a commit that referenced this issue Oct 10, 2015
@feimosi
Copy link
Author

feimosi commented Oct 14, 2015

Hi, thanks for resolving the issue, but after the update all the directives' content lost JS specific highlighting - the whole code is of one color as below:
angular
angularsyntax
Also somehow ng-required is displayed in two colors. I'd appreciate if you could look into it.

@outsideris outsideris reopened this Oct 15, 2015
@outsideris
Copy link
Contributor

Thank you for reporting. I'd appreciate if you reopen the issue next time you get the issue again.
I could miss the issue if it is closed.

@feimosi
Copy link
Author

feimosi commented Oct 15, 2015

I exactly wanted to do so, but couldn't find the Reopen option. It looks like I don't have a permission to that unless I close the issue myself.

@outsideris
Copy link
Contributor

Oops! I didn't know that. Sorry about that. :)

@feimosi
Copy link
Author

feimosi commented Oct 15, 2015

No problem :)

@outsideris outsideris removed their assignment Mar 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants