Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Commit

Permalink
fix(tabs): remove superfluous href from tabs template
Browse files Browse the repository at this point in the history
  • Loading branch information
@pkozlowski-opensource
pkozlowski-opensource committed Mar 19, 2013
1 parent 22a00cd commit 38c1bad
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion template/tabs/tabs.html
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<div class="tabbable">
<ul class="nav nav-tabs">
<li ng-repeat="pane in panes" ng-class="{active:pane.selected}">
<a href="" ng-click="select(pane)">{{pane.heading}}</a>
<a ng-click="select(pane)">{{pane.heading}}</a>
</li>
</ul>
<div class="tab-content" ng-transclude></div>
Expand Down

5 comments on commit 38c1bad

@nathasm
Copy link

@nathasm nathasm commented on 38c1bad May 8, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is in the spirit of bootstrap. In bootstrap when you hover over a tab, the pointer/hand cursor is shown. By removing the href, the text cursor is now used.

@mromanuk
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nathasm is correct, without the href the text cursor is showing which is awkward.

@pkozlowski-opensource
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nathasm @mromanuk so we've got a bit of a problem here as those additional href attributes were breaking apps of several people - basically those links were triggering navigation (page reload). Sadly I never saw a reproduce scenario for this reload case so hard to say what was the exact problem.

In any case dropping href attributes is the AngularJS-way of creating clickable links. So we seem to have a bit of a conflict here between Bootstrap's spirit and AngularJS spirit.

Not sure how to make both happy here but I figured that it is easier to change CSS as compared to tracking down reload issues.

@ajoslin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm.. We could possibly add a style="cursor: pointer;" attribute to the template instead? Since it is different than the bootstrap default.

@bekos
Copy link
Contributor

@bekos bekos commented on 38c1bad May 18, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajoslin This will be problematic for example in disabled state.

Please sign in to comment.