fix(tooltip): switch to use raw DOM event bindings

- Switch to use `addEventListener` and `removeEventListener` to prevent jqLite/jQuery bug where the events are swallowed on disabled elements
angular-ui · Sep 1, 2015 · 97a5663 · 97a5663
1 parent ae6583d
commit 97a5663
Show file tree

Hide file tree

Showing 4 changed files with 154 additions and 103 deletions.
diff --git a/src/tooltip/test/tooltip-template.spec.js b/src/tooltip/test/tooltip-template.spec.js
@@ -30,8 +30,14 @@ describe('tooltip template', function() {
     tooltipScope = elmScope.$$childTail;
   }));
 
+  function trigger(element, evt) {
+    evt = new Event(evt);
+
+    element[0].dispatchEvent(evt);
+  }
+
   it('should open on mouseenter', inject(function() {
-    elm.trigger('mouseenter');
+    trigger(elm, 'mouseenter');
     expect( tooltipScope.isOpen ).toBe( true );
 
     expect( elmBody.children().length ).toBe( 2 );
@@ -41,7 +47,7 @@ describe('tooltip template', function() {
     scope.templateUrl = null;
     scope.$digest();
 
-    elm.trigger('mouseenter');
+    trigger(elm, 'mouseenter');
     expect(tooltipScope.isOpen).toBe(false);
 
     expect(elmBody.children().length).toBe(1);
@@ -51,7 +57,7 @@ describe('tooltip template', function() {
     scope.myTemplateText = 'some text';
     scope.$digest();
 
-    elm.trigger('mouseenter');
+    trigger(elm, 'mouseenter');
     expect(tooltipScope.isOpen).toBe(true);
 
     expect(elmBody.children().eq(1).text().trim()).toBe('some text');
@@ -63,7 +69,7 @@ describe('tooltip template', function() {
   }));
 
   it('should hide tooltip when template becomes empty', inject(function($timeout) {
-    elm.trigger('mouseenter');
+    trigger(elm, 'mouseenter');
     expect(tooltipScope.isOpen).toBe(true);
 
     scope.templateUrl = '';