Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

tabset type attribute requires extra quotes #1409

Closed
jonnypolite opened this issue Dec 13, 2013 · 2 comments
Closed

tabset type attribute requires extra quotes #1409

jonnypolite opened this issue Dec 13, 2013 · 2 comments

Comments

@jonnypolite
Copy link

When declaring a tabset, the type attribute will not function unless it is passed a variable.

For example:

<tabset type="'tabs'">

Will function correctly, but this is not intuitive to the user. This happens because the attribute value is passed to scope.$parent.$eval(), which will return undefined if used in the manner documented below:

<tabset type="tabs">
@bekos
Copy link
Contributor

bekos commented Dec 14, 2013

I agree, and I think that this is a change that we must consider for the whole library in order to keep things consistent.

@jonnypolite Can you investigate similar changes that need to be made in other directives also? Also a PR for this would be very helpful :-)

@pkozlowski-opensource
Copy link
Member

Alert is another example of a directive where we could change type to be passed as @ instead of =.

bekos added a commit to bekos/bootstrap that referenced this issue Dec 24, 2013
Closes angular-ui#1409

BREAKING CHANGE: Use interpolation for type attribute.

  Before:

  <tabset type="'pills'" ...></tabset >
  or
  <tabset type="navtype" ...></tabset>

  After:

  <tabset type="pills" ...></tabset>
  or
  <tabset type="{{navtype}}" ...></tabset>
bekos added a commit to bekos/bootstrap that referenced this issue Jan 8, 2014
Closes angular-ui#1409

BREAKING CHANGE: Use interpolation for type attribute.

  Before:

  <tabset type="'pills'" ...></tabset >
  or
  <tabset type="navtype" ...></tabset>

  After:

  <tabset type="pills" ...></tabset>
  or
  <tabset type="{{navtype}}" ...></tabset>
bekos added a commit to bekos/bootstrap that referenced this issue Jan 20, 2014
Closes angular-ui#1409

BREAKING CHANGE: Use interpolation for type attribute.

  Before:

  <tabset type="'pills'" ...></tabset >
  or
  <tabset type="navtype" ...></tabset>

  After:

  <tabset type="pills" ...></tabset>
  or
  <tabset type="{{navtype}}" ...></tabset>
bekos added a commit that referenced this issue Jan 20, 2014
Closes #1409

BREAKING CHANGE: Use interpolation for type attribute.

  Before:

  <tabset type="'pills'" ...></tabset >
  or
  <tabset type="navtype" ...></tabset>

  After:

  <tabset type="pills" ...></tabset>
  or
  <tabset type="{{navtype}}" ...></tabset>
@bekos bekos closed this as completed in 3bef6e9 Jan 21, 2014
bekos added a commit that referenced this issue Jan 21, 2014
Closes #1409

BREAKING CHANGE: Use interpolation for type attribute.

  Before:

  <tabset type="'pills'" ...></tabset >
  or
  <tabset type="navtype" ...></tabset>

  After:

  <tabset type="pills" ...></tabset>
  or
  <tabset type="{{navtype}}" ...></tabset>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants