Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Carousel not working with angularjs 1.2.7 + bootstrap 3.0.3 #1565

Closed
vquach718 opened this issue Jan 12, 2014 · 28 comments
Closed

Carousel not working with angularjs 1.2.7 + bootstrap 3.0.3 #1565

vquach718 opened this issue Jan 12, 2014 · 28 comments

Comments

@vquach718
Copy link

I tried to use carousel control, but it's only work on first slide, and then pause forever. The control buttons (prev, and next) didn't work either.

@mvhecke
Copy link
Contributor

mvhecke commented Jan 12, 2014

Could you please provide a demo in a Plunk, so we can verify if this is a new bug. At this point Angular 1.2.x isn't supported yet, although I guess it will released in a few days.

@bekos
Copy link
Contributor

bekos commented Jan 12, 2014

@dinhvan5481 This seems to work fine here: http://plnkr.co/edit/SEJLWKwlODUetp6q23rG?p=preview.
As @Gamemaniak said, if you cannot share a minimal reproduce scenario we cannot help.

Closing, but feel free to reopen when you have something to show.

@bekos bekos closed this as completed Jan 12, 2014
@couclock
Copy link

Actually, there is an identified issue when you want to use carousel when ngAnimate is loaded as dependance.
See plunker the same as yours with the inclusion of angular-animate : http://plnkr.co/edit/gwoxr1wj9h7YgpkLS11P?p=preview
Carousel stops at the second slide.

See #1350 to get a workaround.

@vquach718
Copy link
Author

Thank @couclock very much. I tried to re-create the issue on plunker, but couldn't.

@nickjuntilla
Copy link

Thanks guys. Commenting out ngAnimate did it for me! I'm not sure what I had ngAnimate in for now, but this seems like a big issue. Thanks!

@smstone2006
Copy link

Yes,Commenting out ngAnimate did it for me too!Thanks!

@Aqzhyi
Copy link

Aqzhyi commented Apr 22, 2014

Still not working with jQuery 2.1.0 + angular 1.2.16 + ngAniamte 1.2.16 + bootstrap 3.1.1 + angular-ui 0.10.0 ?

Google chrome 34.0.1847.116

http://plnkr.co/edit/EzeZ6KKPfHe0draKUItn?p=preview

By the way

# coffeescript
$timeout -> $animate.enabled off, angular.element(".carousel")
// js
$timeout(function() {
  return $animate.enabled(false, angular.element(".carousel"));
});

this trick working for me.

@atul221282
Copy link

@Pleasurazy it is not working for me but ur plunker seems to be working im using ui-bootstrap-tpls-0.10.0,
Bootstrap css v3.0.1
AngularJS v1.2.16

@anthonyzz
Copy link

Very interesting issue. And this issue makes me think of a WinForms UI Carousel control I got to know recently. From the carousel control tutorial in C#, I can tell they are the similar thing but quite different in implementation. Looks like a novice in JS need to dig deeper.

@metzger84
Copy link

Confirming the issue. Angular v1.2.16 + ngAnimate. Will this get fixed?

@mvidailhet
Copy link

This issue is actually also referenced here : #1350

Someone has given a workaround but it seems it's not fixed yet.

@ncoma
Copy link

ncoma commented Nov 10, 2014

We are on November and it hasn't been fixed yet.
Just to remind you ngAnimate is the problem that causes the carousel to stop working.

@blrzzzt
Copy link

blrzzzt commented Dec 6, 2014

Wow thanks for this thread, I was so confused as to why my slideshows randomly broke!

@Natas0007
Copy link

Has this still not been resolved? Removing ngAnimate isn't an option for me.

@rammere
Copy link

rammere commented Dec 26, 2014

any one got this problem solved 👎 ?

@Stratus3D
Copy link

I am still experiencing this issue as well. Thankfully @Pleasurazy's workaround fixed the issue for me.

@Natas0007
Copy link

Yeah i used the directive workaround. Kinda lame but gets the job done.
On Feb 4, 2015 11:46 AM, "Trevor Brown" notifications@github.com wrote:

I am still experiencing this issue as well. Thankfully @Pleasurazy
https://github.com/Pleasurazy's workaround fixed the issue for me.


Reply to this email directly or view it on GitHub
#1565 (comment)
.

@Stratus3D
Copy link

I actually moved mine to the config block:

app.config(
    ['$animateProvider',
    function ($animateProvider) {
        $animateProvider.classNameFilter(/carousel/);
    }]);

This means ngAnimate is disabled for all elements in the application with the carousel class.

@karianna karianna reopened this Feb 6, 2015
@sonicparke
Copy link

@Stratus3D Thanks! That worked for me.

@dinesh36
Copy link

@Stratus3D Thanks! Thanks! Thanks! Thanks! Thanks! Thanks! That worked for me too.

@bobbajs
Copy link

bobbajs commented Mar 28, 2015

Disabling ngAnimate works for me, but I need animation for elements inside my carousel. Is there a proper fix for this so carousel works with ngAnimate?

@chrisirhc
Copy link
Contributor

This is fixed on master.

@rvanbaalen
Copy link
Contributor

@texasinstrument Like @chrisirhc said, it's fixed in the master branch, not in v0.12.1. Can you try again by using the master branch?

@karianna karianna removed the PRs plz! label Mar 30, 2015
@karianna karianna added this to the 0.13.0 milestone Mar 30, 2015
@karianna
Copy link
Contributor

Closing - can be reopened if OP finds its not fixed on master.

@deisbel
Copy link

deisbel commented Apr 3, 2015

@Stratus3D Thanks!
I downloaded the module two days ago and the issue is still present. I had to apply the parch!

@mikethejet
Copy link

The same issue on Bootstrap v3.3.1 and Angular 1.3.10

@karianna karianna reopened this Apr 14, 2015
@chrisirhc
Copy link
Contributor

This is on master, it hasn't been released. I think you're referring to downloading the released module on the angular-ui/bootstrap website. The master build can only be obtained by cloning the code and building.

@ShauneDonohue
Copy link

ShauneDonohue commented Sep 13, 2016

In my case I was using require.js to load ui-bootstrap, angular-animate was listed as a dependency. Then in my controller I also had angular-animate as a required module. I am assuming this was causing it to be loaded twice, removing angular-animate from my controller fixed the problem and angular-animate was still being loaded.
Versions were ui-bootstrap v2.1.3, Bootstrap CSS v3.3.7 and AngularJS v1.5.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests