Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Always pad hours and minutes in the timepicker #2314

Closed
mbuttu opened this issue Jun 9, 2014 · 2 comments
Closed

Always pad hours and minutes in the timepicker #2314

mbuttu opened this issue Jun 9, 2014 · 2 comments

Comments

@mbuttu
Copy link
Contributor

mbuttu commented Jun 9, 2014

Right now the timepicker only pads the minutes and hours when the template is first loaded. The hours and minutes are not padded when the model changes.

This makes it difficult to create a custom template for the timepicker that uses <select> elements to let the user choose the hour and minutes. The problem is shown in this plunkr.

The hours and minutes are initially selected correctly. To see the issue, try changing the values to a number less than 10.

mbuttu added a commit to mbuttu/bootstrap that referenced this issue Jun 9, 2014
The timepicker only padded the minutes and hours when the template first
loaded. The hours and minutes are now also padded when the model
changes.

Fixes angular-ui#2314.
mbuttu added a commit to mbuttu/bootstrap that referenced this issue Jun 10, 2014
The timepicker only padded the minutes and hours when the template first
loaded. The hours and minutes are now also padded when the model
changes.

Fixes angular-ui#2314.
@wesleycho
Copy link
Contributor

This should be an opt in feature.

@wesleycho
Copy link
Contributor

Closing in favor of #4288.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants