Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Default carousel template is not accessible #4478

Closed
evan-duncan opened this issue Sep 25, 2015 · 6 comments
Closed

Default carousel template is not accessible #4478

evan-duncan opened this issue Sep 25, 2015 · 6 comments

Comments

@evan-duncan
Copy link

  • Angular - 1.2.28
  • ui-bootstrap - 0.11.2

Here is a plunker of a failing scenario: http://plnkr.co/edit/pouPdsf3ugooUiyHMPTV?p=preview

The default template is not accessible via keyboard navigation nor with screen reader assistance. While tabbing through the document you should be able to get keyboard focus on the carousel controls. While using assistive technology, you should also be able to tab-stop on the carousel controls. Neither of these are working as-is.

I understand that newer versions allow for custom templates but there are very minimal changes to the default template that would allow all versions to be much more accessible.

@wesleycho
Copy link
Contributor

This is way too old of a version for us to support - for reference, that version was released 1 year ago (minus one day).

@pkozlowski-opensource
Copy link
Member

@wesleycho the way I understood what @eduncan26 was saying is that we still got this issue...
@eduncan26 did you try the latest release? Can you see the same accessibility issues? A lot of work went into improving this area.

@wesleycho wesleycho reopened this Sep 25, 2015
@evan-duncan
Copy link
Author

You have the same accessibility issues with the latest release -- the only thing that really helps is that you support custom templates in 0.13. The default template between 0.11 and 0.13 is essentially the same. I understand not wanting to support 0.11, but the default template should be more accessible than it is currently.

For my project I have updated to 0.13 because I need to make the carousel accessible. I can get you a PR today for improved accessibility just by changing the markup. The accessibility team I work with has also suggested focus path improvements as well (refocus the slide on slide change).

@wesleycho
Copy link
Contributor

Do you happen to know what changes are necessary for accessibility? It would help speed things up if you're willing to file a PR with the fixes necessary - otherwise we can try figuring it out.

@evan-duncan
Copy link
Author

I'll get you a PR shortly

@pkozlowski-opensource
Copy link
Member

I'll get you a PR shortly

Awesome @eduncan26 ! This is the open source spirit!

@wesleycho wesleycho added this to the 0.14.0 (Bootstrap 3.3) milestone Sep 25, 2015
jasonaden pushed a commit to deskfed/bootstrap that referenced this issue Jan 8, 2016
- Improves accessibility of carousel

Closes angular-ui#4478
Closes angular-ui#4479
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants