Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

custom-class not geting applied for Datepicker in year mode. #4546

Closed
Sheeryada opened this issue Oct 7, 2015 · 8 comments
Closed

custom-class not geting applied for Datepicker in year mode. #4546

Sheeryada opened this issue Oct 7, 2015 · 8 comments

Comments

@Sheeryada
Copy link

I tried to pass custom class for datepicker. I tried to pass custom class when datepicker is in year mode and it is not applying it. However the same works fine when datepicker is in day and month mode.

Please confirm me if it is a bug?

@icfantv
Copy link
Contributor

icfantv commented Oct 8, 2015

@Sheeryada, please do not use the issues forum for support related requests. Rather, please follow the instructions here.

@Sheeryada
Copy link
Author

Hi @icfantv thanks for your reply. I feel this is a bug,

Here is the plunker http://plnkr.co/edit/qvWGqcyS5GYpOuffOs7k?p=preview

Please see no class getting added when datepicker is in year mode. I inspected the element and see no custom-classes getting added when in year mode.

Do you agree if this is a bug? or please let me know if I am missing anything?

here is the screenshot it appears as ,
image
image
image

@icfantv
Copy link
Contributor

icfantv commented Oct 8, 2015

Yep. It's a bug. The template for year.html is missing ng-class="::dt.customClass" on the <td> wrapping the <button>.

@icfantv icfantv reopened this Oct 8, 2015
@Sheeryada
Copy link
Author

@icfantv thanks for your confirmation and for reopening this issue.

That's a quick investigation on the issue!.

icfantv added a commit to icfantv/bootstrap that referenced this issue Oct 8, 2015
* add missing custom class to year picker

fixes angular-ui#4546
@icfantv
Copy link
Contributor

icfantv commented Oct 8, 2015

You're welcome. And thanks for following the instructions for how to properly submit a bug report. As most of us have day jobs, it's quite difficult for us to also do that and create working plunkers that reproduce the issue so we rely heavily on you end-users to prove it's an actual issue before we can act. I should have posted the link to the bug reporting instructions so that's on me. My bad.

@icfantv icfantv closed this as completed in 0ad7cb9 Oct 8, 2015
@Sheeryada
Copy link
Author

No worries.. Thanks...

@icfantv
Copy link
Contributor

icfantv commented Oct 9, 2015

@Sheeryada, we released 0.14.0 last night and this fix is contained in that release so if you upgrade to the latest you will have this fix. Please be sure to look at the CHANGELOG.md to go through the changes.

@Sheeryada
Copy link
Author

@icfantv Thank you for the update.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants