Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Carousel corrupted if render slides with ng-repeat and cnahge slide set. #4823

Closed
sergik opened this issue Nov 5, 2015 · 2 comments
Closed

Comments

@sergik
Copy link

sergik commented Nov 5, 2015

Carusel corrupted if render slides with ng-repeat and cnahge slides collsection. Slides animations throttled with internal flag $scope.$currentTransition. This flag prevents moving to next slide if carusel is in slide change process. When changing slides collection this flag leaves in true state and carusel is corrupted. See the example. http://plnkr.co/edit/FNijUvcOjsXocqmtP3bh?p=preview.
Press "kill me" and wait for a second. This example emulates fast 2 time change of an active slide.

sergik pushed a commit to sergik/bootstrap that referenced this issue Nov 5, 2015
@sergik
Copy link
Author

sergik commented Nov 5, 2015

could potentialy relate to #4667. Submitted a pull request for this: #4824

@sergik sergik changed the title Carusel corrupted if render slides with ng-repeat and cnahge slide set. Carousel corrupted if render slides with ng-repeat and cnahge slide set. Nov 5, 2015
@mchurichi
Copy link

Here is another example of the same issue happening when you add a bunch of slides after the carousel has been fully loaded: http://plnkr.co/edit/NyG9yX?p=preview. This pull request doesn't solve the issue in this case.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants