Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

popover-append-to-body does not work #4945

Closed
cdauth opened this issue Nov 24, 2015 · 4 comments
Closed

popover-append-to-body does not work #4945

cdauth opened this issue Nov 24, 2015 · 4 comments

Comments

@cdauth
Copy link

cdauth commented Nov 24, 2015

According to the documentation, the attribute popover-append-to-body can be added to elements using the uib-popover directive. I has no effect though, as can be seen in this plunker.

@pkozlowski-opensource
Copy link
Member

You need to use popover-append-to-body="true". I think that we've got an issue somewhere to trugger this functionality using a boolean attribute only as you've tried.

@Foxandxss as you can see this is not only ng2 thing :-)

@cdauth
Copy link
Author

cdauth commented Nov 24, 2015

Thanks for the tip, in fact it seems to work.

This seems to be an inconsistency, as dropdown-append-to-body works without ="true", for example.

Also, the documentation should mention this.

icfantv added a commit to icfantv/bootstrap that referenced this issue Nov 25, 2015
* fix `tooltip-append-to-body` doc
* fix `popover-append-to-body` doc

Fixes angular-ui#4945
@cdauth
Copy link
Author

cdauth commented Nov 25, 2015

@icfantv, thanks for taking care of the issue.

Either I am missing something, or I think there is a misunderstanding. You added to the docs that “the presence of the attribute implies true”. It is the issue of my report that in fact it does not, as opposed to the dropdown-append-to-body attribute.

@RobJacobs
Copy link
Contributor

There was a previous discussion on this where someone chimed in and said they use *-append-to-body="true" in a global config and turned it off on a case by case basis using *-append-to-body="false". If we are going to change this, I think it needs to still evaluate the attribute value but default to true and be consistent across all directives.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants