This repository has been archived by the owner on May 29, 2019. It is now read-only.
feat(modal): add pluggable resolve support #5078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
feat/modal-resolve
branch
from
022f2a3
to
979b8bf
Compare
|
This is pretty slick @wesleycho. Nice work. |
wesleycho
force-pushed
the
feat/modal-resolve
branch
from
979b8bf
to
6818dc6
Compare
|
I am good but the docs doesn't conform the design I have now. But not sure how to do it either. |
|
Also if post 1.0 is not going to have it, it is a bit "temporary" |
|
Well, I am talking with the UI Router folks, it's trivial to re-add support & they're open to it, but it may require a documentation update to explain how to use it afterwards. |
|
That guy with sunglasses called @christopherthielen pss. LGTM, it is a good addition indeed. I like our modal API like ng1 routes. Let see what we achieve with ngbs. |
|
Oh wait, forgot about the doc thing. |
wesleycho
force-pushed
the
feat/modal-resolve
branch
from
6818dc6
to
dd3f40a
Compare
- Adds support for pluggable resolvers, namely for supporting UI Router's resolve handling
wesleycho
force-pushed
the
feat/modal-resolve
branch
from
dd3f40a
to
f59bfe0
Compare
|
LGTM |
|
@wesleycho @icfantv Has this been discontinued in the current version 2.5.0? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature in action here.
This implements #3405.