This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(grunt): do not inject uib css by default (issue #5548) #5557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -436,7 +436,7 @@ module.exports = function(grunt) { | |||
| .replace(/\\/g, '\\\\') | |||
| .replace(/'/g, "\\'") | |||
| .replace(/\r?\n/g, '\\n'); | |||
| js = `angular.module('ui.bootstrap.${moduleName}').run(function() {!angular.$$csp().noInlineStyle && angular.element(document).find('head').prepend('<style type="text/css">${css}</style>'); });`; | |||
| js = `angular.module('ui.bootstrap.${moduleName}').run(function() {!angular.$$csp().noInlineStyle && angular.$$uibInjectCss && angular.element(document).find('head').prepend('<style type="text/css">${css}</style>'); });`; | |||
There was a problem hiding this comment.
I would prefer this to just be called $$uibCss. In addition, it needs !angular.$$uibCss before the style tag injection and && angular.$$uibCss = true at the end of the expression.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Injecting CSS in the run block causes memory leaks when running jasmine tests