Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(grunt): do not inject uib css by default (issue #5548) #5557

Closed
wants to merge 2 commits into from

Conversation

pusherman
Copy link

Injecting CSS in the run block causes memory leaks when running jasmine tests

@@ -436,7 +436,7 @@ module.exports = function(grunt) {
.replace(/\\/g, '\\\\')
.replace(/'/g, "\\'")
.replace(/\r?\n/g, '\\n');
js = `angular.module('ui.bootstrap.${moduleName}').run(function() {!angular.$$csp().noInlineStyle && angular.element(document).find('head').prepend('<style type="text/css">${css}</style>'); });`;
js = `angular.module('ui.bootstrap.${moduleName}').run(function() {!angular.$$csp().noInlineStyle && angular.$$uibInjectCss && angular.element(document).find('head').prepend('<style type="text/css">${css}</style>'); });`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer this to just be called $$uibCss. In addition, it needs !angular.$$uibCss before the style tag injection and && angular.$$uibCss = true at the end of the expression.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleycho updated

@wesleycho wesleycho closed this in cc2d1b9 Mar 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants