Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(dropdown): use .value() for uibDropdownConfig #6006

Closed
wants to merge 1 commit into from

Conversation

onlywei
Copy link
Contributor

@onlywei onlywei commented Jun 14, 2016

This allows people to use .decorator() to customize this object.
#6004.

This allows people to use .decorator() to customize this
object.
@wesleycho
Copy link
Contributor

Note that the issue shouldn't be closed, as this should be done for every component.

@wesleycho
Copy link
Contributor

Unfortunately, I'm going to have to revert this since it turns out this is a breaking change (the constant becomes no longer injectable inside a config function).

@onlywei
Copy link
Contributor Author

onlywei commented Jun 15, 2016

@wesleycho why is that a breaking change? I grepped through the src/ directory and found that it was not being injected into any config functions.

@pkozlowski-opensource
Copy link
Member

I grepped through the src/ directory and found that it was not being injected into any config functions.

But users of this lib might be doing so.

@onlywei
Copy link
Contributor Author

onlywei commented Jun 15, 2016

I see. In that case, going forward, will the below be the recommended way for users of the lib to configure the dropdown library?

import angular from 'angular';
import uibDropdown from 'angular-ui-bootstrap/src/dropdown';

angular.module('MyApp', [uibDropdown])
  .config(function (uibDropdownConfig) {
    uibDropdownConfig.openClass = 'is-open';
  });

?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants