fix(carousel): cancel timer on scope destroyed

[chrisirhc]

My take on this fix based on @joshkurz 's findings.

At first I thought that the go function should check if the scope is destroyed, but I realized that it doesn't have to as long as only one timeout can be set at one time. If only one timeout can be set at one time, the scope $destroyed event just has to cancel it.

I'm also thinking of moving the go function out of the restartTimer as the function is always the same doesn't need to be recreated on each timer run.

TODO:

• Move go function out of restartTimer

Fixes #1414

[bekos]

@chrisirhc You should also extract this code:

if (currentTimeout) {
      $timeout.cancel(currentTimeout);
      currentTimeout = null;
}

into its own function as it is called multiple times.

[chrisirhc]

Makes sense. I'll do that when I wake heh. Just about to sleep.
Update: Just did it.

[pkozlowski-opensource]

Simply awesome. It is in master already!

[joshkurz]

so it seems that the issue is still not fixed. from this punker. http://plnkr.co/edit/kMrUtWy3fQqgHwNdHSLO?p=preview. The issue persists with the master code. Im not 100% but I believe if you ran the $destroy test I wrote in #1423, it would fail as the $timeouts are still created after the scope is destroyed here.

[chrisirhc]

@joshkurz , you're right. This is caused by

bootstrap/src/carousel/carousel.js

Lines 25 to 29 in 0b39994

	if ($scope.$currentTransition) {
	$scope.$currentTransition.cancel();
	//Timeout so ng-class in template has time to fix classes for finished slide
	$timeout(goNext);
	} else {

and I'll fix that in a follow-up PR.

[joshkurz]

nice job @chrisirhc