-
Notifications
You must be signed in to change notification settings - Fork 6.7k
chore(demo): update demo page for bootstrap3 #1469
Conversation
There is a spelling error: |
Good catch; updated |
Also removed angular-bootstrap-affix.js as it wasn't used anymore. pushed again.
|
cool! probably want to remove jquery also as I added that with the affix plugin. |
On |
done and done 👊 |
Just going through, to add more eyeballs on the demo.. There are two Popup title labels for the Popover demo. I think the first one is the button label. (I'll create a PR for that) Otherwise, looks good! 👍 |
thanks @chrisirhc! updated 👊 I removed the ng-model on the button label as it seemed like extraneous / confusing information. |
Adds new header, mobile menu, fastclick, smooth scrolling, and more.
@ajoslin agreed! I was thinking of doing that too ha. Doesn't seem like a necessary part of the demo of popover. |
Awesome job @thienedits and @ajoslin !!! I've just corrected links to BS3 and landed it in the bootstrap3 branch. I believe that we are now ready to officially release the Bootstrap3 support, yay! I'm going to spend some time today looking at the demo page and going over all the opened issues / PRs but if there are no roadblocks I will be cutting a release tomorrow!!! |
that's a very good news cause tomorrow I'll start a new project and was wondering when you guys will start the dances ready to be a beta tester! |
We must add the |
Squashed #1331, rebased to latest, and added a few tweaks. Should be good to merge.