Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

chore(demo): update demo page for bootstrap3 #1469

Closed
wants to merge 1 commit into from

Conversation

ajoslin
Copy link
Contributor

@ajoslin ajoslin commented Dec 26, 2013

Squashed #1331, rebased to latest, and added a few tweaks. Should be good to merge.

@bekos
Copy link
Contributor

bekos commented Dec 26, 2013

There is a spelling error: jumobotron. These css rules are never used, so can be safely removed, instead of corrected.

@ajoslin
Copy link
Contributor Author

ajoslin commented Dec 26, 2013

Good catch; updated

@ajoslin
Copy link
Contributor Author

ajoslin commented Dec 26, 2013

Also removed angular-bootstrap-affix.js as it wasn't used anymore. pushed again.

  1. set up PR
  2. Look at it
  3. See problem
  4. fix
  5. force-push
  6. Go to step 3

@thienedits
Copy link
Contributor

cool! probably want to remove jquery also as I added that with the affix plugin.

@bekos
Copy link
Contributor

bekos commented Dec 26, 2013

On tabs demo, it is introduced again the btn-small class, instead of btn-sm which is the correct one .

@ajoslin
Copy link
Contributor Author

ajoslin commented Dec 26, 2013

done and done 👊

@chrisirhc
Copy link
Contributor

Just going through, to add more eyeballs on the demo.. There are two Popup title labels for the Popover demo. I think the first one is the button label. (I'll create a PR for that)

Otherwise, looks good! 👍

@ajoslin
Copy link
Contributor Author

ajoslin commented Dec 26, 2013

thanks @chrisirhc! updated 👊

I removed the ng-model on the button label as it seemed like extraneous / confusing information.

Adds new header, mobile menu, fastclick, smooth scrolling, and more.
@chrisirhc
Copy link
Contributor

@ajoslin agreed! I was thinking of doing that too ha. Doesn't seem like a necessary part of the demo of popover.

pkozlowski-opensource pushed a commit that referenced this pull request Dec 27, 2013
Adds new header, mobile menu, fastclick, smooth scrolling, and more.

Closes #1243
Closes #1469
@pkozlowski-opensource
Copy link
Member

Awesome job @thienedits and @ajoslin !!! I've just corrected links to BS3 and landed it in the bootstrap3 branch. I believe that we are now ready to officially release the Bootstrap3 support, yay!

I'm going to spend some time today looking at the demo page and going over all the opened issues / PRs but if there are no roadblocks I will be cutting a release tomorrow!!!

@AdamQuadmon
Copy link

that's a very good news cause tomorrow I'll start a new project and was wondering when you guys will start the dances

ready to be a beta tester!

bekos pushed a commit that referenced this pull request Dec 28, 2013
Adds new header, mobile menu, fastclick, smooth scrolling, and more.

Closes #1243
Closes #1469
@bekos
Copy link
Contributor

bekos commented Dec 28, 2013

We must add the .panel-title a to the list of elements that need cursor pointer. Did this before in this commit and forced push but somehow is lost :-)

pkozlowski-opensource pushed a commit that referenced this pull request Dec 28, 2013
Adds new header, mobile menu, fastclick, smooth scrolling, and more.

Closes #1243
Closes #1469
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants