Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(carousel): Exposing $scope.currentIndex for index of current slide #2089

Closed
wants to merge 2 commits into from
Closed

Conversation

circuitrider
Copy link

Allows templates to access currentIndex, which is the index of the slide currently active. This allows for per-slide customized behavior in navigation such as disabling the 'prev' button on the first slide or the 'next' button on the last slide.

This opens the door for greater customization and more complex templating of the carousel.

Allows templates to access currentIndex, which is the index of the slide currently active. This allows for per-slide customized behavior in navigation such as disabling the 'prev' button on the first slide or the 'next' button on the last slide. 

This opens the door for greater customization and more complex templating of the carousel.
@bekos
Copy link
Contributor

bekos commented Apr 21, 2014

@circuitrider Thx for the PR but the currentIndex inside the directive is not always the same index of the slide in the carousel. There is an issue open for this and something like this is not going to work as long as this bug exists. Closing, also because there are no tests that would probably expose that issue.

@bekos bekos closed this Apr 21, 2014
@circuitrider
Copy link
Author

Do you know of an existing Issue about this item you can link me to? I
wouldn't mind taking a second pass at solving this with these greater
considerations in mind. My company will be using this framework and I'd be
more than glad to help with its growth and improvement.

On Mon, Apr 21, 2014 at 2:32 AM, Tasos Bekos notifications@github.comwrote:

@circuitrider https://github.com/circuitrider Thx for the PR but the
currentIndex inside the directive is not always the same index of the slide
in the carousel. There is an issue open for this and something like this is
not going to work as long as this bug exists. Closing, also because there
are no tests that would probably expose that issue.


Reply to this email directly or view it on GitHubhttps://github.com//pull/2089#issuecomment-40925497
.

@bekos
Copy link
Contributor

bekos commented Apr 21, 2014

@circuitrider Yes sure, check #488. It would be awesome if you can contribute an elegant solution to this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants