This repository has been archived by the owner on May 29, 2019. It is now read-only.
Pull req ISSUE #3554 (Expose $modalstack openedWindows) #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this please. |
|
I would argue that we shouldn't merge this. As described in #3554 there is a way of doing things with a decorator, without extending the public API surface. Exposing internal data structure for not-so-common use-case (for which an elegant solutions with a decorator) will limit our ability to change internal data structures in the future. |
|
@pkozlowski-opensource - Thanks for the review! Closing as wontfix. |
|
Here is a plunkr that demonstrates the $delegate approach: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.