Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: change font files path #3751

Closed
brucejcw opened this issue Jun 11, 2015 · 11 comments · Fixed by #6750
Closed

suggestion: change font files path #3751

brucejcw opened this issue Jun 11, 2015 · 11 comments · Fixed by #6750

Comments

@brucejcw
Copy link

I'm using gulp to manage my project, and a standard dist folder structure is like:
screen shot 2015-06-11 at 7 21 48 pm

As in the screnshot, all the fonts will be moved to fonts folder, but in angular-ui-grid folder, all the {css, fonts} are in the same folder level,
screen shot 2015-06-11 at 7 23 43 pm
screen shot 2015-06-11 at 7 24 14 pm

So it will cause (404) error, because the fonts path changed to (../fonts/ui-grid.ttf), not ('ui-grid.ttf')
I suggest to create a font foler and style folder like bootstrap does, Or any good way to config in gulp?

@brucejcw brucejcw changed the title suggestion: change font files place suggestion: change font files path Jun 11, 2015
@jonathanhds
Copy link

+1

@luchsamapparat
Copy link

+1

@maxim-danilov
Copy link

+1
I got this problem when using Generator Gulp Angular.

@maxim-danilov
Copy link

Okay, I added task in gulp build:

gulp.task('fontsUiGrid', function() {
    gulp.src('./bower_components/angular-ui-grid/**/*.{ttf,woff}')
        .pipe(gulp.dest(path.join(conf.paths.dist, '/styles/')));
});

gulp.task('build', ['html', 'fonts', 'other', 'fontsUiGrid']);

And it worked!

@ghost
Copy link

ghost commented Aug 24, 2016

gulp build puts fonts into fonts directory.. but ui-grid seeking them in styles directory.. when you are going to fix this issue?

@antoniogiroz
Copy link

+1

4 similar comments
@ghost
Copy link

ghost commented Feb 21, 2017

+1

@phvajjha
Copy link

+1

@otaviosoares
Copy link

+1

@peterlitvak
Copy link

+1

@stale
Copy link

stale bot commented May 23, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label May 23, 2018
mportuga pushed a commit that referenced this issue Jun 12, 2018
BREAKING CHANGE: If you take the new CSS and do not relocate the icon files your icons will cease to
show in the grid.

fix #3751
mportuga pushed a commit that referenced this issue Jun 12, 2018
BREAKING CHANGE: If you take the new CSS and do not relocate the icon files your icons will cease to
show in the grid.

fix #3751
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
BREAKING CHANGE: If you take the new CSS and do not relocate the icon files your icons will cease to
show in the grid.

fix angular-ui#3751
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants