Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cellNav error #4035

Closed
Bv202 opened this issue Jul 23, 2015 · 14 comments
Closed

cellNav error #4035

Bv202 opened this issue Jul 23, 2015 · 14 comments

Comments

@Bv202
Copy link

Bv202 commented Jul 23, 2015

Hey,

When enabling cell navigation, I'm getting this error when the grid loads:
TypeError: uiGridCtrl.focus is not a function

The keyboard navigation is NOT working.

What's going wrong here? I'm using the latest stable version (3.0.1).

Thanks

@JLLeitschuh
Copy link
Contributor

This should be fixed in #3850.
However, if you have a stack trace that would be helpful.

@Bv202
Copy link
Author

Bv202 commented Jul 23, 2015

Hey,

I'll see if I can post that tomorrow.

I'm getting this error when combining row select and cellnav. The reason I want both is because I want the user to navigate between certain cells to change their values. This is seperated from selecting whole rows.

@tonyeung
Copy link

Here's mine, I was going to do a bit more troubleshooting but found this issue so what the hey, here it is.

The apologies on the nonsense file and row numbers, my files are concatenated and there are no sourcemaps

Uncaught TypeError: Cannot read property 'getNextRowCol' of undefined
module.directive.compile.pre.uiGridCtrl.cellNav.handleKeyDown @ app.js:55834
(anonymous function) @ app.js:57060
jQuery.event.dispatch @ app.js:4435
jQuery.event.add.elemData.handle @ app.js:4121

The first error happens in uiGridCelnav

if (lastRowCol) {
                  // Figure out which new row+combo we're navigating to
                  var rowCol = uiGridCtrl.grid.renderContainers[containerId].cellNav.getNextRowCol(direction, lastRowCol.row, lastRowCol.col);

@tonyeung
Copy link

I traced it down to cellNav not existing on the container for some reason

@tonyeung
Copy link

This seems to be a separate issue, I'm going to be creating a new issues instead.
In short, cellNav works on body but not on pinned (left in this case) columns.

EDIT: found an issue ticket that seems to be the same issue I'm experiencing
#3459

@tonyeung
Copy link

version ui-grid - v3.0.1 - 2015-07-17

@tonyeung
Copy link

building the master now to see if this issue is fixed there

@tonyeung
Copy link

Built master, referenced it, still no good

@swalters
Copy link
Contributor

can you create a plunkr that recreates it?

@tonyeung
Copy link

@swalters thar she is: http://plnkr.co/edit/pz2gACcGc3glqCs0mZlP?p=preview

Repro by clicking on any field on the left column, press tab, nothing happens.
Console will show error I posted.
Curiously, a second tab will bring focus over to the body container and cellnav works as expected.
The current bower version and the master version i built (which crashed over and over again until i ran grunt --force) both behave this way.

Also, I feel bad jacking this issue when I don't think its related to it, can we migrate these comments?

@swalters
Copy link
Contributor

I see the issue. should have fix soon

@tonyeung
Copy link

yay! i didn't waste your time. Its always embarrassing when its something stupid on my end. I was sure I had missed a flag somewhere or something.

swalters added a commit that referenced this issue Jul 31, 2015
… built after body is rendered

fixes one of issues in #4035
@swalters
Copy link
Contributor

@tonyeung this should fix your issue. @Bv202 you can try it also. Might have fixed your issue as well.

@tonyeung
Copy link

confirmed fixed my issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants