Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Grid Bug- Agg:remove is not working #5682

Closed
rKS2827 opened this issue Sep 19, 2016 · 1 comment · Fixed by #6828
Closed

UI Grid Bug- Agg:remove is not working #5682

rKS2827 opened this issue Sep 19, 2016 · 1 comment · Fixed by #6828

Comments

@rKS2827
Copy link

rKS2827 commented Sep 19, 2016

In Ui-Grid table I am using aggregate function ,but on agg:remove getting error in console "TypeError: aggregation.col.treeAggregationFn is not a function" .After click on agg:remove not able to apply aggregate function on other columns.

check this image for error http://i.stack.imgur.com/6Ja7t.png
Here is plnkr https://plnkr.co/edit/lTkddSNhfLPHQfuldWfs?p=preview

please review it asap

@mportuga
Copy link
Member

I believe that adding a angular noop for a default function or checking if treeAggregationFn is a function.

mportuga pushed a commit that referenced this issue Aug 4, 2018
Added fallback for when removing aggregations.

fix #5682
mportuga pushed a commit that referenced this issue Aug 4, 2018
Added fallback for when removing aggregations.

fix #5682
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
Added fallback for when removing aggregations.

fix angular-ui#5682
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants