Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to navigate through grid menu #6482

Closed
ShibyNiju opened this issue Nov 27, 2017 · 1 comment · Fixed by #6621
Closed

Not able to navigate through grid menu #6482

ShibyNiju opened this issue Nov 27, 2017 · 1 comment · Fixed by #6621
Assignees

Comments

@ShibyNiju
Copy link

ShibyNiju commented Nov 27, 2017

The grid menu items is not navigatable using keyboard. When the grid menu is opened, focus should be on the first menu item, so that arrow keys can be used to navigate through the items.

The ui-grid.js has the code for this, but its not working

@ShibyNiju
Copy link
Author

ShibyNiju commented Nov 30, 2017

Got the cause of the issue. The first button was hidden and hence focus setting to first button was not effective.

The following code in showMenu method :

//automatically set the focus to the first button element in the now open menu.
gridUtil.focus.bySelector($elm, 'button[type=button]', true);

should be changed as follows :

gridUtil.focus.bySelector($elm, 'button[type=button]:not(.ng-hide)', true);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants