4.4.5: Infinite loop with cellnav and enableCellEditOnFocus

[m4m4m4]

In ui-grid 4.4.5, with cell-nav and cell-edit features enabled with enableCellEditOnFocus set to true.
Navigating to the last row in the grid gets stuck in an infinite loop (cpu in the tab goes often to 100%) or becomes un-editable

I am able to reproduce the error in the following plunker for both chrome and firefox.
Steps to reproduce: expand all rows, scroll to the bottom, select a cell in the bottom row
http://plnkr.co/edit/cVIvvBzZ6clPMEZzWAjr?p=preview

• This is a bug report, not a question on how to use the grid.
  Use Stack Overflow or Gitter for questions.
• You have searched the open issues to see if this bug has been filed before. We don't want duplicate issues.
• You have reviewed the tutorials and documentation to ensure you are using the grid correctly. ui-grid.info
• You are using the latest version of the grid. Older versions are not patched or supported.
• You have provided steps to recreate your bug. A plunkr is even better.

[mportuga]

This was most likely caused by the following commit:
87c9eed

We need to check it and see what needs to be done to resolve this issue without reintroducing the bugs that it fixed.

[m4m4m4]

The problem seems to go away if I remove the shorter "rowHeight: 23" and in my local environment I also need to remove "enableHorizontalScrollbar: 2".

[m4m4m4]

Thanks for being so fast with this
Something is still not 100% right, if i click on a top cell where it is only half visible due to scroll, the infinite loop often reappears. It's easy to reproduce in the same plunker but the latest version:
http://plnkr.co/edit/PS3lTnLrqiXSE58iHFhC?p=preview, try scrolling down a bit and then select a cell in the top row
Also in my local environment the bottom cell bug is still there if I use "enableHorizontalScrollbar: 2", I am not able to reproduce that error in the plunker however.

[mportuga]

Alright, thanks for the information. I am going to have to do some more analysis to figure out why the loop reappears.

[m4m4m4]

Nevermind.. this doesnt solve when navigating by keys, the loop is still there but not visible.

[m4m4m4]

The following commit should do it for now. It however feels like i am fixing a symptom and not the underlying cause.

Since cellNav feature calls ScrollIfNecessary when navigating, I am not sure why the method needs to be called again from edit feature when enableCellEditOnFocus is active (which requires cellnav).
I would like to implement a fix like below, but there are a couple of tests failing that stops me from doing so.

function beginEdit(triggerEvent) { 
	if (gridCol.colDef.enableCellEditOnFocus === true) { 
		//If enableCellEditOnFocus is enabled cell will already be focused 
		beginEditAfterScroll(triggerEvent); 
	} 
	else { 
		//we need to scroll the cell into focus before invoking the editor 
		$scope.grid.api.core.scrollToIfNecessary($scope.row, $scope.col) .then(function () { 
			beginEditAfterScroll(triggerEvent); 
		}); 
	} 
}
`