Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

angular.lowercase and angular.uppercase methods removed in angular 1.7 #6715

Closed
oklymenk opened this issue May 1, 2018 · 1 comment · Fixed by #6722
Closed

angular.lowercase and angular.uppercase methods removed in angular 1.7 #6715

oklymenk opened this issue May 1, 2018 · 1 comment · Fixed by #6722
Assignees
@mportuga
Labels
good first issue

Comments

@oklymenk
Copy link

oklymenk commented May 1, 2018

angular-ui-grid v4.4.9 is using angular.lowercase and angular.uppercase methods that are now removed in angular 1.7.0-rc.0.

https://github.com/angular/angular.js/blob/v1.7.0-rc.0/CHANGELOG.md

The helper functions angular.lowercase and angular.uppercase have been removed.

These functions have been deprecated since 1.5.0. They are internally used, but should not be exposed as they contain special locale handling (for Turkish) to maintain internal consistency regardless of user-set locale.

Developers should generally use the built-ins toLowerCase and toUpperCase or toLocaleLowerCase and toLocaleUpperCase for special cases.

Further, we generally discourage using the angular.x helpers in application code.
@mportuga mportuga self-assigned this May 1, 2018
@mportuga
Copy link
Member

mportuga commented May 3, 2018

Same goes for removeData

mportuga pushed a commit that referenced this issue May 11, 2018
fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S…
5010ff0 
…tring.toUpperCase and .toLowerC

This will allow us to support angular 1.7 when it becomes available.

fix #6715
@mportuga mportuga mentioned this issue May 11, 2018
Merged
mportuga pushed a commit that referenced this issue May 11, 2018
@mportuga
fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S…
a41677a 
…tring.toUpperCase and .toLowerC

This will allow us to support angular 1.7 when it becomes available.

fix #6715
defields923 pushed a commit to defields923/ui-grid that referenced this issue Oct 30, 2018
fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S…
4aa9ab4 
…tring.toUpperCase and .toLowerC

This will allow us to support angular 1.7 when it becomes available.

fix angular-ui#6715
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mportuga mportuga

Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ui-grid-util.js): Replace angular.uppercase and .lowercase with S… angular-ui/ui-grid
2 participants
@mportuga @oklymenk