Extend the edit feature to support dropdowns #1570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes creation of a new tutorial, extension of the old tutorial, and provision of unit tests.
|
instead of having Yet Another Option, I prefer the developer to set the editableCellTempate to dropDownEditor.html. This keeps things simple and gives each template a single responsibility without needless ng-if's. We can't keep growing this edit template to include every possible editor. It's ok to keep these: |
|
Replaced by #1579 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes creation of a new tutorial, extension of the old tutorial,
and provision of unit tests.
Updated from #1561 to provide for a filter on the options list of the dropdown, allowing translations on the dropdown values (using a tool like angular-translate).