Fixed scrolling when verticalScrollHeight is 0

[ghost]

Open the basic example:
http://ui-grid.info/docs/#/tutorial/101_intro
Hover above the grid and try to scroll up - it doesn't scroll the page.
Scrolling down, however, works.

This fixes it

[villelahdenvuo]

Duplicates: #3666 #3531 #3340 (for reference)

[swalters]

@500tech-user Can you tell me is this still an issue in master? I think this was fixed in some other commits.

[swalters]

ok, I see that mousewheel is still broken for it

[swalters]

Thanks for PR.

Rather than putting the logic where you have it, we would rather see the verticalScrollLength property added to scrollEvent and then the atBottom, atTop, atLeft, and atRight can use that number to determine if it is at bottom, top, etc.

I'll look at making this change and will close this PR when complete.

[swalters]

Should be fixed with
e582174 . Thanks for the PR

[ghost]

Awesome
BTW, I also noticed that when zooming in or out the calculation is wrong.
Did you ever encounter that?

• Adam Klein http://il.linkedin.com/in/adamklein500
• CTO @ 500Tech.com http://500tech.com/ - Web and Mobile development
• hackademy.co.il http://hackademy.co.il/angularjs/about - AngularJS,
  Ruby on Rails training
• (+972) 52 747 5633

On Fri, Jun 19, 2015 at 5:50 AM, Shane Walters notifications@github.com
wrote:

Closed #3690 #3690.

—
Reply to this email directly or view it on GitHub
#3690 (comment).

[rhrasna]

The problem persists in v.3.0.1.