Updating column width when columnDefs changes #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test failure: |
|
@lpand a single commit is preferred for pull requests. You can squash yours and and force push it to your fork. Here's a guide on how to do it: https://github.com/ginatrapani/todo.txt-android/wiki/Squash-All-Commits-Related-to-a-Single-Issue-into-a-Single-Commit |
…column definition set column width to * if coldef's width is not a number or a suitable string just refresh the canvas after a column is resized
|
First time i read about this feature of git... Nice. |
c0bra
added a commit
that referenced
this pull request
Jul 1, 2015
Updating column width when columnDefs changes
|
LGTM. Thanks a lot, @lpand! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #3880. The width of the column definition should have precedence over the current column width.
Maybe it'd be better to put that block of code into a separated method?