Removed the X and Close on menu, and implemented-ESC and cyclical tabs #5068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do I improve this code quality? None of the issues described in that review were lines changed in this PR. |
|
@dlgski the codacy check was added to build thinking it would only check the changes and not then entire code base. If it can't be configured to do this, we will remove it. I'll review your PR soon. Thanks. |
…lical tabbing codacy recommended code improvements only grab menu items that are visible
swalters
added a commit
that referenced
this pull request
Feb 8, 2016
Removed the X and Close on menu, and implemented-ESC and cyclical tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ARIA, an X and Close menu option had been implemented into the column menus. This PR removes those and implements the ESC key to close the menu via a keyboard. It also makes sure tabbing is cyclical, so tabbing continuously will keep you contained within the menu.