Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Do not clear condition when clearing all filters #5361

Merged
merged 1 commit into from
Nov 7, 2016
Merged

fix(core): Do not clear condition when clearing all filters #5361

merged 1 commit into from
Nov 7, 2016

Conversation

lebolo
Copy link
Contributor

@lebolo lebolo commented Apr 26, 2016 •
edited
Loading

Current Behavior: Grid menu option Clear all filters removes all filter conditions as well as search terms.

Problem: Users expect Clear all filters to only remove search terms, but leave conditions as is so that filters can still be used to search the table. Essentially, we expect Clear all fitlers to be the same as going through each filter and clicking the small x next to it.

Fix: Clear all filters only removes search terms and leaves conditions as is.

Fixes #4657

fix(core): Do not clear condition when clearing all filters
97be89a 
When a user clicks the grid menu's "clear all filters", do not remove the filter's 9possibly custom)

`condition`.

Fixes #4657
@lebolo lebolo mentioned this pull request Apr 26, 2016
Closed
@JLLeitschuh
Copy link
Contributor

I'm not sure I understand what/why this change is necessary. What is the behaviour before without this fix? What is it now??

@lebolo
Copy link
Contributor Author

lebolo commented May 27, 2016 •
edited
Loading

Sorry about that @JLLeitschuh, I thought it was explicit enough to say that Clear all filters should not remove filter conditions, i.e. it should only remove search terms. I'll edit the description.

More details are in the linked issue, particularly #4657 (comment)

@drGarbinsky
Copy link

Currently hitting this bug. Anything can to do help move this forward? I've tested the change proposed and all looks good.

@lebolo
Copy link
Contributor Author

lebolo commented Jun 24, 2016 •
edited
Loading

I believe the majority of ui-grid developers have moved on or are really busy. They're currently looking to fill the the void, but I don't know when we'll see the next release :(

@AgDude
Copy link
Contributor

AgDude commented Jul 30, 2016

I am in favor of merging this, but it will be a breaking change. @dlgski

@el-davo
Copy link

el-davo commented Oct 4, 2016

Hi All, Any updates on when this is likely to be merged, or is it going to be merged?

drGarbinsky
drGarbinsky approved these changes Oct 4, 2016
View reviewed changes
Copy link

@drGarbinsky drGarbinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been testing this change in production for several months without issue. Let me know if there is anything I can do to help get this merged

@mportuga
Copy link
Member

@drGarbinsky We will likely include it in the next big release.

@mportuga mportuga merged commit 5b73e8a into angular-ui:master Nov 7, 2016
@mportuga mportuga mentioned this pull request Jun 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drGarbinsky drGarbinsky drGarbinsky approved these changes

Assignees
No one assigned
Labels
breaking Looks Good To Me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lebolo @JLLeitschuh @drGarbinsky @AgDude @el-davo @mportuga