feat(core): Reduce digest triggers when using $timeout #5829
Conversation
Angular's $timeout takes a boolean 3rd parameter which causes the wrapped function to not run inside $apply. Since $timeout is used extensively in scope, this parameter has been passed where possible in order to improve performance, since the grid otherwise triggers a large number of digests while functioning normally. See issue: angular-ui#5007
|
Anyone around to take a look at this? |
|
@MichalJakubeczy @csvan i will try to see if I can include at least part of these changes in the next release of UI-grid. The original version was causing some ui-problems. The most noticeable one that I remember, was a case where I had a toggle-able filter row with a pinned column. In that scenario, for whatever reason, there was either a delay between the pinned and the unpinned filter row display, or it was just partially displaying things. I seem to recall some other UI issues, but none quite as memorable. |
|
@mportuga thanks for your answer. Any performance improvements would be awesome as we are struggling with that a bit. Anyway, when is a new release planned would it be angular 1.6.2 compatible? |
|
We are trying to do a minor release soon with the PRs that we merged recently. I think there was one of them that adds some catch statements that make it work a bit better with angular 1.6, but it is not necessarily making it angular 1.6 compatible. Right now we are concentrating on performance and memory leaks since those are the big issues that we need fixed. But we would welcome any PR which makes 1.6 support possible. |
Re-implemented some of @csvan's work with PR angular-ui#5829 and improved refreshCanvas function. 5007
| var promise = $timeout(focusBySelector); | ||
| this.queue.push($timeout(focusBySelector)); | ||
| var promise = $timeout(focusBySelector, 0, false); | ||
| this.queue.push($timeout(focusBySelector), 0, false); |
There was a problem hiding this comment.
@csvan there is a mistake here, should be:
this.queue.push($timeout(focusBySelector, 0, false));right?
Re-implemented some of @csvan's work with PR angular-ui#5829 and improved refreshCanvas function. 5007
Angular's $timeout takes a boolean 3rd parameter which, if
false, causes the wrapped function to not run inside $apply. Since $timeout is used extensively in core, this parameter has been passed where possible in order to improve performance. Previously, the grid would trigger a large number of digests even when working normally, see issue: #5007.This is very low-hanging fruit. It is possible the same investigation can be applied across the plugins as well.