This repository has been archived by the owner on Sep 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 198
Initial proposal #2
Merged
douglasduteil
merged 6 commits into
angular-ui:master
from
douglasduteil:ft-project-root
Nov 21, 2013
Merged
Initial proposal #2
douglasduteil
merged 6 commits into
angular-ui:master
from
douglasduteil:ft-project-root
Nov 21, 2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
I like it, it's clean. My only question is, what's the reasoning behind restricting |
Thanks @nateabele <div class="ui-layout" ui-layout-opts="{ flow : 'row' }"></div>
<div ui-layout ui-layout-opts="{ flow : 'row' }"></div> // Bad looking
<div ui-layout="{ flow : 'row' }"></div>
<ui-layout ui-layout-opts="{ flow : 'row' }"></ui-layout> What you think ? |
Ah, I wasn't thinking about the CSS issue. However, I think you can change the selector to As far as syntax, I prefer the terseness of either of these two: <div ui-layout="{ flow : 'row' }"></div>
<ui-layout options="{ flow : 'row' }"></ui-layout> How's that? |
Sweet 👍 |
you can now create a layout like : ```html <div ui-layout="{ flow : 'row' }"></div> or <ui-layout options="{ flow : 'row' }"></ui-layout> ```
Are the splitters width and height properties configurable. For instance, could it detect bootstrap grid to size spliters? |
stchar
pushed a commit
to stchar/ui-layout
that referenced
this pull request
Aug 19, 2015
Remove console.log from ui-layout.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I'm done working on a fist version of a splitter.
What you think ?