Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Initial proposal #2

Merged
merged 6 commits into from
Nov 21, 2013
Merged

Conversation

douglasduteil
Copy link
Contributor

@ggoodman ggoodman mentioned this pull request Nov 20, 2013
@nateabele
Copy link
Contributor

I like it, it's clean. My only question is, what's the reasoning behind restricting ui-layout to class-only? IMO a better pattern would be to use it as an attribute if nothing else.

@douglasduteil
Copy link
Contributor Author

Thanks @nateabele
Why it's class-only ? No reason... I was testing stuff cause the css must match. But I can clearly do more!

<div class="ui-layout" ui-layout-opts="{ flow : 'row' }"></div>
<div ui-layout ui-layout-opts="{ flow : 'row' }"></div> // Bad looking
<div ui-layout="{ flow : 'row' }"></div>
<ui-layout ui-layout-opts="{ flow : 'row' }"></ui-layout>

What you think ?

@nateabele
Copy link
Contributor

Ah, I wasn't thinking about the CSS issue. However, I think you can change the selector to .ui-layout, [ui-layout], ui-layout { ... } to match all 3.

As far as syntax, I prefer the terseness of either of these two:

<div ui-layout="{ flow : 'row' }"></div>
<ui-layout options="{ flow : 'row' }"></ui-layout>

How's that?

@douglasduteil
Copy link
Contributor Author

Sweet 👍

you can now create a layout like :

```html
<div ui-layout="{ flow : 'row' }"></div>
or
<ui-layout options="{ flow : 'row' }"></ui-layout>
```
douglasduteil added a commit that referenced this pull request Nov 21, 2013
@douglasduteil douglasduteil merged commit 6e48a96 into angular-ui:master Nov 21, 2013
@ticlaudeberube
Copy link

Are the splitters width and height properties configurable. For instance, could it detect bootstrap grid to size spliters?

stchar pushed a commit to stchar/ui-layout that referenced this pull request Aug 19, 2015
Remove console.log from ui-layout.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants